This shows you the differences between two versions of the page.
Both sides previous revision Previous revision | Next revision Both sides next revision | ||
fuel_opnfv_guidelines [2015/10/03 17:06] Jonas Bjurel |
fuel_opnfv_guidelines [2015/10/04 19:51] Jonas Bjurel [Review procedures] |
||
---|---|---|---|
Line 38: | Line 38: | ||
* Usee 0 if you just want to communicate through the comment field, 0 without any comments doesn't make sense and shall be avoided. | * Usee 0 if you just want to communicate through the comment field, 0 without any comments doesn't make sense and shall be avoided. | ||
* Use +1 if you agree with the patch, don't vote +1 on your own patches. | * Use +1 if you agree with the patch, don't vote +1 on your own patches. | ||
- | * Use +2 if you agree with the patch and want it merged, don't vote +2 on your own patches unless the project lead agrees and don't vote +2 until a chorum has voted +1 or a 24 hour period has passed. | + | * Use +2 if you agree with the patch and want it merged, don't vote +2 on your own patches unless the project lead agrees, and don't vote +2 until a chorum has voted +1 or a 24 hour period has passed. |
===== Merge procedures ===== | ===== Merge procedures ===== |